Skip to content

Adds enhanced support for proxy models. #603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 9, 2019
Merged

Adds enhanced support for proxy models. #603

merged 6 commits into from
Jun 9, 2019

Conversation

@abettke
Copy link

@abettke abettke commented Mar 27, 2019

  • Allows for proxy models to be used directly in DjangoObjectType definitions.
  • Updates tests for proxy model support.
  • Removes test showing proxied DjangoObjectType definitions fail.

@abettke abettke mentioned this pull request Mar 27, 2019
Closed
@coveralls
Copy link

coveralls commented Mar 27, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.01%) to 94.226% when pulling a7ee042 on abettke:fix/enhanced-proxy-model-support into 090ce6e on graphql-python:master.

zbyte64
zbyte64 requested changes Mar 27, 2019
View reviewed changes
@abettke abettke mentioned this pull request Mar 27, 2019
Closed
phalt
phalt reviewed Apr 1, 2019
View reviewed changes
Copy link
Contributor

@phalt phalt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need any documentation to go along with it?

@abettke
Copy link
Author

abettke commented Apr 1, 2019

Does this need any documentation to go along with it?

None that I can think of. This just adds, what seems to me, expected behavior. Beforehand, using a proxy model in a DjangoObjectType threw a GraphQLError. Now, it fully supports using proxy models the same way that base models are used.

@threewordphrase
Copy link

threewordphrase commented Apr 5, 2019

I'm waiting with bated breath for this :)

@firaskafri firaskafri requested a review from jkimbo April 6, 2019 07:58
@abettke
Copy link
Author

abettke commented Apr 6, 2019 •
edited
Loading

For anyone needing this immediately (as my company did), my fork contains theses changes, and as far as I know is currently up to date with master.

auvipy
auvipy approved these changes Apr 17, 2019
View reviewed changes
Copy link

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work!

@mvanlonden mvanlonden merged commit b271b25 into graphql-python:master Jun 9, 2019
@jkimbo jkimbo mentioned this pull request Jul 9, 2019
Merged
@IAmNatch
Copy link

IAmNatch commented Sep 7, 2019

Note to anyone searching: Upgrading from 2.2.0 to 2.4.0 resolved my issue with serializing a taggit proxy model. Thanks all who worked on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zbyte64 zbyte64 zbyte64 approved these changes

@danpalmer danpalmer danpalmer approved these changes

@firaskafri firaskafri firaskafri approved these changes

@jkimbo jkimbo Awaiting requested review from jkimbo

+2 more reviewers

@phalt phalt phalt left review comments

@auvipy auvipy auvipy approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@abettke @coveralls @threewordphrase @IAmNatch @zbyte64 @danpalmer @phalt @firaskafri @auvipy @mvanlonden